Add type to const, change const name

This commit is contained in:
brabli
2024-08-05 12:01:40 +01:00
parent 5c87bf35d5
commit 58d0e93fc9

View File

@@ -10,7 +10,7 @@ use PHPUnit\Framework\TestCase;
class MappableTraitTest extends TestCase class MappableTraitTest extends TestCase
{ {
private const FLOAT = 123.456; private const float COORD = 123.456;
private MappableInterface $obj; private MappableInterface $obj;
@@ -21,7 +21,7 @@ class MappableTraitTest extends TestCase
public function testSetLatitude(): void public function testSetLatitude(): void
{ {
$this->assertInstanceOf(MappableInterface::class, $this->obj->setLatitude(self::FLOAT)); $this->assertInstanceOf(MappableInterface::class, $this->obj->setLatitude(self::COORD));
} }
public function testGetLatitudeReturnsNull(): void public function testGetLatitudeReturnsNull(): void
@@ -31,13 +31,13 @@ class MappableTraitTest extends TestCase
public function testGetLatitude(): void public function testGetLatitude(): void
{ {
$this->obj->setLatitude(self::FLOAT); $this->obj->setLatitude(self::COORD);
$this->assertSame(self::FLOAT, $this->obj->getLatitude()); $this->assertSame(self::COORD, $this->obj->getLatitude());
} }
public function testSetLongitude(): void public function testSetLongitude(): void
{ {
$this->assertInstanceOf(MappableInterface::class, $this->obj->setLongitude(self::FLOAT)); $this->assertInstanceOf(MappableInterface::class, $this->obj->setLongitude(self::COORD));
} }
public function testGetLongitudeReturnsNull(): void public function testGetLongitudeReturnsNull(): void
@@ -47,8 +47,8 @@ class MappableTraitTest extends TestCase
public function testGetLongitude(): void public function testGetLongitude(): void
{ {
$this->obj->setLongitude(self::FLOAT); $this->obj->setLongitude(self::COORD);
$this->assertSame(self::FLOAT, $this->obj->getLongitude()); $this->assertSame(self::COORD, $this->obj->getLongitude());
} }
public function testIsGeocodedReturnsFalse(): void public function testIsGeocodedReturnsFalse(): void
@@ -58,20 +58,20 @@ class MappableTraitTest extends TestCase
public function testIsGeocodedReturnsFalseIfLatIsSet(): void public function testIsGeocodedReturnsFalseIfLatIsSet(): void
{ {
$this->obj->setLatitude(self::FLOAT); $this->obj->setLatitude(self::COORD);
$this->assertFalse($this->obj->isGeocoded()); $this->assertFalse($this->obj->isGeocoded());
} }
public function testIsGeocodedReturnsFalseIfLonIsSet(): void public function testIsGeocodedReturnsFalseIfLonIsSet(): void
{ {
$this->obj->setLongitude(self::FLOAT); $this->obj->setLongitude(self::COORD);
$this->assertFalse($this->obj->isGeocoded()); $this->assertFalse($this->obj->isGeocoded());
} }
public function testIsGeocodedReturnsTrueIfLatAndLonAreSet(): void public function testIsGeocodedReturnsTrueIfLatAndLonAreSet(): void
{ {
$this->obj->setLatitude(self::FLOAT); $this->obj->setLatitude(self::COORD);
$this->obj->setLongitude(self::FLOAT); $this->obj->setLongitude(self::COORD);
$this->assertTrue($this->obj->isGeocoded()); $this->assertTrue($this->obj->isGeocoded());
} }
@@ -89,5 +89,5 @@ class MappableTraitTest extends TestCase
use MappableTrait; use MappableTrait;
}; };
} }
} }