pcm-libraries/pcm-geocode-bundle
2
0
Fork 0
Code Issues 2 Releases Activity

Add types to consts

Browse Source
This commit is contained in:
brabli
2024-08-05 12:01:33 +01:00
parent 84ba22f287
commit 5c87bf35d5
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Service/Geocoder.php
View File

@@ -10,7 +10,7 @@ use Symfony\Contracts\HttpClient\ResponseInterface;
class Geocoder class Geocoder
{ {
private const API_URL = "https://nominatim.openstreetmap.org/search"; private const string API_URL = "https://nominatim.openstreetmap.org/search";
public function __construct(private HttpClientInterface $client) {} public function __construct(private HttpClientInterface $client) {}

5
tests/Service/GeocodeTest.php
View File

@@ -12,12 +12,12 @@ use Pcm\GeocodeBundle\Tests\AppKernel;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase; use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/** /**
* Note we sleep 1s after requests to prevent breaking the API T&Cs * We sleep 1 second after API calls to prevent breaking the API T&Cs.
*/ */
class GeocodeTest extends KernelTestCase class GeocodeTest extends KernelTestCase
{ {
// Buckingham Palace // Buckingham Palace
private const POSTCODE = 'SW1A 1AA'; private const string POSTCODE = 'SW1A 1AA';
private Geocoder $geocoder; private Geocoder $geocoder;
@@ -54,3 +54,4 @@ class GeocodeTest extends KernelTestCase
}; };
} }
} }