pcm-libraries/pcm-geocode-bundle
2
0
Fork 0
Code Issues 2 Releases Activity

Throw exceptions when something goes wrong instead of returning null

Browse Source
This commit is contained in:
brabli
2024-08-05 13:07:04 +01:00
parent fcda1e931c
commit a6c8c4cc0c
2 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Service/Geocoder.php
View File

@@ -4,6 +4,8 @@ declare(strict_types=1);
namespace Pcm\GeocodeBundle\Service;
use Pcm\GeocodeBundle\Exception\ApiErrorException;
use Pcm\GeocodeBundle\Exception\NoResultsFoundException;
use Pcm\GeocodeBundle\Model\GeoCoordinates;
use Symfony\Contracts\HttpClient\HttpClientInterface;
use Symfony\Contracts\HttpClient\ResponseInterface;
@@ -26,13 +28,12 @@ final class Geocoder
$response = $this->makeApiRequest($client, $postcode);
$data = $this->getDataFromResponse($response);
// @todo remove check, I don't think it's needed
if (empty($data)) {
return null;
if (array_key_exists('error', $data)) {
throw new ApiErrorException($postcode, $data['error']['message']);
}
if (array_key_exists('error', $data)) {
return null;
if (empty($data)) {
throw new NoResultsFoundException($postcode, "No results found.");
}
return $this->createGeoCoordinates($data);