pcm-libraries/pcm-geocode-bundle
2
0
Fork 0
Code Issues 2 Releases Activity

Mark classes as final

Browse Source
This commit is contained in:
brabli
2024-08-05 12:09:10 +01:00
parent cb16158eb3
commit f30c20ceda
6 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Model/LatLongModel.php
View File

@@ -9,7 +9,7 @@ namespace Pcm\GeocodeBundle\Model;
* *
* @package Pcm\GeocodeBundle * @package Pcm\GeocodeBundle
*/ */
class LatLongModel final class LatLongModel
{ {
public function __construct(private float $latitude, private float $longitude) {} public function __construct(private float $latitude, private float $longitude) {}

2
src/PcmGeocodeBundle.php
View File

@@ -10,7 +10,7 @@ use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigura
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader; use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
use Symfony\Component\HttpKernel\Bundle\AbstractBundle; use Symfony\Component\HttpKernel\Bundle\AbstractBundle;
class PcmGeocodeBundle extends AbstractBundle { final class PcmGeocodeBundle extends AbstractBundle {
public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void
{ {
$loader = new YamlFileLoader($builder, new FileLocator(__DIR__.'/../config/')); $loader = new YamlFileLoader($builder, new FileLocator(__DIR__.'/../config/'));

2
src/Service/Geocoder.php
View File

@@ -8,7 +8,7 @@ use Pcm\GeocodeBundle\Model\LatLongModel;
use Symfony\Contracts\HttpClient\HttpClientInterface; use Symfony\Contracts\HttpClient\HttpClientInterface;
use Symfony\Contracts\HttpClient\ResponseInterface; use Symfony\Contracts\HttpClient\ResponseInterface;
class Geocoder final class Geocoder
{ {
private const string API_URL = "https://nominatim.openstreetmap.org/search"; private const string API_URL = "https://nominatim.openstreetmap.org/search";

3
tests/AppKernel.php
View File

@@ -9,7 +9,7 @@ use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Component\Config\Loader\LoaderInterface; use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\HttpKernel\Kernel; use Symfony\Component\HttpKernel\Kernel;
class AppKernel extends Kernel final class AppKernel extends Kernel
{ {
/** /**
* @return array * @return array
@@ -30,3 +30,4 @@ class AppKernel extends Kernel
$loader->load(__DIR__.'/config_'.$this->getEnvironment().'.yml'); $loader->load(__DIR__.'/config_'.$this->getEnvironment().'.yml');
} }
} }

2
tests/Service/GeocodeTest.php
View File

@@ -14,7 +14,7 @@ use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/** /**
* We sleep 1 second after API calls to prevent breaking the API T&Cs. * We sleep 1 second after API calls to prevent breaking the API T&Cs.
*/ */
class GeocodeTest extends KernelTestCase final class GeocodeTest extends KernelTestCase
{ {
// Buckingham Palace // Buckingham Palace
private const string POSTCODE = 'SW1A 1AA'; private const string POSTCODE = 'SW1A 1AA';

2
tests/Trait/MappableTraitTest.php
View File

@@ -8,7 +8,7 @@ use Pcm\GeocodeBundle\Entity\Interface\MappableInterface;
use Pcm\GeocodeBundle\Entity\Trait\MappableTrait; use Pcm\GeocodeBundle\Entity\Trait\MappableTrait;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
class MappableTraitTest extends TestCase final class MappableTraitTest extends TestCase
{ {
private const float COORD = 123.456; private const float COORD = 123.456;