From 173c08b0d001e6757fb0304ecfeeb99c70811e42 Mon Sep 17 00:00:00 2001 From: Bradley Date: Tue, 27 Jun 2023 10:27:28 +0100 Subject: [PATCH] Use constants for default values --- src/DependencyInjection/Configuration.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index bda3a2e..e4a2847 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -10,6 +10,9 @@ use Symfony\Component\Config\Definition\ConfigurationInterface; class Configuration implements ConfigurationInterface { + public const DEFAULT_SIZE = 32; + public const DEFAULT_COLOUR = 'primary'; + public function getConfigTreeBuilder(): TreeBuilder { $treeBuilder = new TreeBuilder('pcm_icon'); @@ -28,8 +31,8 @@ class Configuration implements ConfigurationInterface ->arrayNode('default') ->addDefaultsIfNotSet() ->children() - ->scalarNode('colour')->defaultValue('primary')->end() - ->integerNode('size')->defaultValue(32)->end() + ->scalarNode('colour')->defaultValue(self::DEFAULT_COLOUR)->end() + ->integerNode('size')->defaultValue(self::DEFAULT_SIZE)->end() ->end() ->end() ->end()