Split extension into extension and runtime classes to match how the maker bundle creates twig extensions

This commit is contained in:
Brabli
2023-05-31 11:51:36 +01:00
parent 08d906260a
commit 493f0c275b
4 changed files with 38 additions and 31 deletions

View File

@@ -5,10 +5,7 @@ declare(strict_types=1);
namespace Pcm\IconBundle;
use Pcm\IconBundle\DependencyInjection\PcmIconExtension;
use Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symfony\Component\HttpKernel\Bundle\AbstractBundle;
class PcmIconBundle extends AbstractBundle

View File

@@ -0,0 +1,22 @@
<?php
declare(strict_types=1);
namespace Pcm\IconBundle\Twig\Extension;
use Pcm\IconBundle\Twig\Runtime\IconRuntime;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;
final class IconExtension extends AbstractExtension
{
/**
* @inheritDoc
*/
public function getFunctions(): array
{
return [
new TwigFunction('icon', [IconRuntime::class, 'renderIcon'])
];
}
}

View File

@@ -2,12 +2,13 @@
declare(strict_types=1);
namespace Pcm\IconBundle\Twig\Functions;
namespace Pcm\IconBundle\Twig\Runtime;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;
use Pcm\IconBundle\Exception\ColourNotFound;
use Pcm\IconBundle\Exception\IconNotFound;
use Twig\Extension\RuntimeExtensionInterface;
final class IconExtension extends AbstractExtension
final class IconRuntime implements RuntimeExtensionInterface
{
public const DEFAULT_SIZE = 32;
@@ -22,18 +23,6 @@ final class IconExtension extends AbstractExtension
public function __construct(private array $directories, private array $colours) {}
/**
* @inheritDoc
*/
public function getFunctions(): array
{
return [
new TwigFunction('icon', [$this, 'renderIcon'], [
'is_safe' => ['html']
])
];
}
/**
* @param array $options
* ```
@@ -211,7 +200,3 @@ final class IconExtension extends AbstractExtension
}
}
}
class IconNotFound extends \Exception {};
class ColourNotFound extends \Exception {};