Some icons look broken due to fill classes #11

New Issue

Open

opened 2024-01-11 10:24:50 +00:00 by bg · 0 comments

bg commented 2024-01-11 10:24:50 +00:00

Owner

Copy Link

Copy Source

<svg xmlns="http://www.w3.org/2000/svg" width="44" height="44" viewBox="0 0 24 24" stroke-width="1.5" stroke="#2c3e50" fill="none" stroke-linecap="round" stroke-linejoin="round">
  <path stroke="none" d="M0 0h24v24H0z" fill="none"/>
  <path d="M3 3l18 18" />
  <path d="M9 5h9a3 3 0 0 1 3 3v8a3 3 0 0 1 -.128 .87" />
  <path d="M18.87 18.872a3 3 0 0 1 -.87 .128h-12a3 3 0 0 1 -3 -3v-8c0 -1.352 .894 -2.495 2.124 -2.87" />
  <path d="M3 11l8 0" />
  <path d="M15 11l6 0" />
  <path d="M7 15l.01 0" />
  <path d="M11 15l2 0" />
</svg>

This is being caused by the classes fill-none, hover:fill-none, group-hover:fill-none.

Perhaps add a flag to disable fill?

fill: false

```svg <svg xmlns="http://www.w3.org/2000/svg" width="44" height="44" viewBox="0 0 24 24" stroke-width="1.5" stroke="#2c3e50" fill="none" stroke-linecap="round" stroke-linejoin="round"> <path stroke="none" d="M0 0h24v24H0z" fill="none"/> <path d="M3 3l18 18" /> <path d="M9 5h9a3 3 0 0 1 3 3v8a3 3 0 0 1 -.128 .87" /> <path d="M18.87 18.872a3 3 0 0 1 -.87 .128h-12a3 3 0 0 1 -3 -3v-8c0 -1.352 .894 -2.495 2.124 -2.87" /> <path d="M3 11l8 0" /> <path d="M15 11l6 0" /> <path d="M7 15l.01 0" /> <path d="M11 15l2 0" /> </svg> ``` This is being caused by the classes `fill-none`, `hover:fill-none`, `group-hover:fill-none`. Perhaps add a flag to disable fill? `fill: false`

bg added the Bug label 2024-01-11 10:24:50 +00:00

This repo is archived. You cannot comment on issues.

No Branch/Tag Specified

Branches Tags

main

develop

issue/10-icons-should-have-ariahiddentrue-attribute-unless-a-title-has-been-specified

issue/8-throw-custom-exception-if-file-could-not-be-parsed-as-an-svg

issue/7-throw-custom-exception-if-svg-file-is-found-but-is-empty

1.1.0

1.0.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.9

0.0.8

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

0.0.1

0.0.0

Labels

Clear labels

Bug

Bug

Improvement

Improvement

In progress

An ongoing task

Question

Question

Ready

Ready for deployment

To Review

To review

No labels Bug

Milestone

No items

No Milestone

Assignees

Clear assignees

bg (Bradley Goode) jd mf (Matt Feeny)

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: pcm-libraries/pcm-icon-bundle#11